Core: Drop support for old jQuery or old browsers #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
drop-old-browsers-jquery
branch
from
eaa62e9
to
a9aa0cd
Compare
timmywil
reviewed
May 13, 2024
mgol
force-pushed
the
drop-old-browsers-jquery
branch
2 times, most recently
from
ea17854
to
01162fa
Compare
mgol
force-pushed
the
drop-old-browsers-jquery
branch
3 times, most recently
from
8f53949
to
7f8d411
Compare
timmywil
reviewed
May 14, 2024
| <script src="../../ui/core.js"></script> | ||
| <script src="../../ui/widget.js"></script> | ||
| <script src="../../ui/mouse.js"></script> | ||
| <script src="../../ui/slider.js"></script> |
There was a problem hiding this comment.
Why doesn't this need to load JS anymore?
There was a problem hiding this comment.
It does still load JS. This was the old way of doing it that also included loading the deprecated core.js file that this PR removes.
This template actually used both ways of loading JS; it looks like a migration oversight. I checked that the demo still works fine after these removals.
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
Also, remove the ability to run the test suite in jQuery <1.12.4 & <2.2.4. Closes jquerygh-2249
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
This follows the naming strategy for other internal properties. Ref jquerygh-2249
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
Avoid relying on jQuery patches. Instead: * use `CSS.escape` instead of `jQuery.escapeSelector` * use `.filter()` with a proper handler instead of `.even()` Keep `jquery-patch.js` for backwards compatibility, though. Also, add tests for jquery-patch. Ref jquerygh-2249
mgol
force-pushed
the
drop-old-browsers-jquery
branch
from
7f8d411
to
837f62e
Compare
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
Also, fix checkboxradio visual tests. Ref jquerygh-2249
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
added a commit
to mgol/jquery-ui
that referenced
this pull request
May 14, 2024
mgol
force-pushed
the
drop-old-browsers-jquery
branch
from
837f62e
to
ba4b0dc
Compare
Also, remove the ability to run the test suite in jQuery <1.12.4 & <2.2.4. Closes jquerygh-2249
This follows the naming strategy for other internal properties. Ref jquerygh-2249
Avoid relying on jQuery patches. Instead: * use `CSS.escape` instead of `jQuery.escapeSelector` * use `.filter()` with a proper handler instead of `.even()` Keep `jquery-patch.js` for backwards compatibility, though. Also, add tests for jquery-patch. Ref jquerygh-2249
Also, fix checkboxradio visual tests. Ref jquerygh-2249
mgol
force-pushed
the
drop-old-browsers-jquery
branch
from
ba4b0dc
to
5f615c2
Compare
|
Landed in daa6fb5...5f615c2. |
fnagel
reviewed
May 24, 2024
| <script src="../../ui/core.js"></script> | ||
| <script src="../../ui/widget.js"></script> | ||
| <script src="../../ui/mouse.js"></script> | ||
| <script src="../../ui/slider.js"></script> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
storedStylesheetto_storedStylesheetCSS.escapeinstead ofjQuery.escapeSelector.filter()with a proper handler instead of.even()ui/core.jsfile